feat(code_review): Forward pull_request events to Seer #105740

armenzg · 2026-01-06T19:50:21Z

This change adds support for forwarding GitHub pull_request events to Seer instead of Overwatch.

src/sentry/seer/code_review/webhooks/pull_request.py

armenzg · 2026-01-06T20:15:55Z

src/sentry/integrations/github/webhook.py

-    WEBHOOK_EVENT_PROCESSORS = (_handle_pr_webhook_for_autofix_processor,)
+    WEBHOOK_EVENT_PROCESSORS = (
+        _handle_pr_webhook_for_autofix_processor,
+        code_review_handle_webhook_event,


Adding this to the PullRequestEventWebhook class which handles pull_request events.

sentry/src/sentry/integrations/github/webhook.py

Line 1041 in 67db771

GithubWebhookType.PULL_REQUEST: PullRequestEventWebhook,

sentry/src/sentry/integrations/github/webhook_types.py

Line 18 in c9bcba8

PULL_REQUEST = "pull_request"

armenzg · 2026-01-06T20:17:11Z

src/sentry/integrations/github/webhook.py

                    sample_rate=1.0,
                    tags={
-                        "organization_id": organization.id,
-                        "repository_id": repo.id,


If you run the tests with verbosity, you can see that these calls to metrics.incr are failing because these two keys are forbidden due to high cardinality.

@ajay-sentry @srest2021 heads up ^ in case you were still using that metric to track billing related stuff for GA

Thanks for catching this!!

armenzg · 2026-01-06T20:21:27Z

src/sentry/testutils/helpers/github.py

    - Sending webhook events with proper authentication
    """

+    OPTIONS_TO_SET: Mapping[str, Any] = {}


New approach to initialized the test classes. The class needs to define which options to set as part of the set up.

tests/sentry/seer/code_review/__init__.py

suejung-sentry

this is great and much simpler than I expected it to be! Nice!

suejung-sentry · 2026-01-06T22:38:32Z

src/sentry/integrations/github/webhook.py


    EVENT_TYPE = IntegrationWebhookEventType.MERGE_REQUEST
-    WEBHOOK_EVENT_PROCESSORS = (_handle_pr_webhook_for_autofix_processor,)
+    WEBHOOK_EVENT_PROCESSORS = (


Just for my own mental model, these 2 processors run serially right?

sentry/src/sentry/integrations/github/webhook.py

Line 176 in 4ba9a5a

for processor in self.WEBHOOK_EVENT_PROCESSORS:

With a failure in 1 does not block the next, and each processor runs synchronous for most of its logic except for the call to seer in schedule_task which is async?

This is correct.

Once the code review processors executes, the work is in the task broker queue and will be handled async.

suejung-sentry · 2026-01-06T22:43:34Z

src/sentry/integrations/github/webhook.py

                    sample_rate=1.0,
                    tags={
-                        "organization_id": organization.id,
-                        "repository_id": repo.id,


@ajay-sentry @srest2021 heads up ^ in case you were still using that metric to track billing related stuff for GA

suejung-sentry · 2026-01-06T22:50:01Z

src/sentry/seer/code_review/webhooks/pull_request.py

+def _get_trigger_for_action(action: PullRequestAction) -> CodeReviewTrigger:
+    if action == PullRequestAction.READY_FOR_REVIEW:
+        return CodeReviewTrigger.ON_READY_FOR_REVIEW
+    return CodeReviewTrigger.ON_NEW_COMMIT


technically this could be something like below so it's not a burden of the caller of the helper to know which actions are actually valid

match action: case PullRequestAction.READY_FOR_REVIEW: return CodeReviewTrigger.ON_READY_FOR_REVIEW case PullRequestAction.SYNCHRONIZE: return CodeReviewTrigger.ON_NEW_COMMIT case _: raise ValueError(f"Unsupported pull request action: {action}")

suejung-sentry · 2026-01-06T22:51:23Z

src/sentry/seer/code_review/webhooks/pull_request.py

+    if action not in WHITELISTED_ACTIONS:
+        return
+
+    if pull_request.get("draft") is True:


Later I'm guessing we're going to want to start tracking this metric later too to inform whether we should allow our feature on drafts or not

I'm not certain if this is necessary since we check the actions and there's a draft action.

suejung-sentry · 2026-01-06T22:51:52Z

src/sentry/testutils/helpers/github.py

        """Helper to set up code review test context."""
        self.organization.update_option("sentry:enable_pr_review_test_generation", True)
        features_to_enable = self.CODE_REVIEW_FEATURES if features is None else features
+        options_to_set = dict(self.OPTIONS_TO_SET) | (options or {})


this is nice

Support sending GitHub `pull_request` events to Seer instead of Overwatch.

src/sentry/seer/code_review/webhooks/pull_request.py

armenzg self-assigned this Jan 6, 2026

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2026

vercel bot deployed to Preview January 6, 2026 19:52 View deployment

cursor bot reviewed Jan 6, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/pull_request.py Outdated Show resolved Hide resolved

armenzg commented Jan 6, 2026

View reviewed changes

armenzg requested a review from suejung-sentry January 6, 2026 20:22

vercel bot deployed to Preview January 6, 2026 20:29 View deployment

suejung-sentry approved these changes Jan 6, 2026

View reviewed changes

armenzg added 2 commits January 7, 2026 07:17

feat(code_review): Forward pull_request events to Seer directly

5dc365f

Support sending GitHub `pull_request` events to Seer instead of Overwatch.

Address recommendation

71fb508

armenzg force-pushed the 1_5/code_review/pull_request/armenzg branch from 0f4e7aa to 71fb508 Compare January 7, 2026 12:20

vercel bot deployed to Preview January 7, 2026 12:23 View deployment

cursor bot reviewed Jan 7, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/pull_request.py Show resolved Hide resolved

armenzg added 2 commits January 7, 2026 12:40

Address Bugbot feedback

f11a77f

Draft case

bd2401a

armenzg marked this pull request as ready for review January 7, 2026 18:54

armenzg requested a review from a team as a code owner January 7, 2026 18:54

armenzg enabled auto-merge (squash) January 7, 2026 18:56

vercel bot deployed to Preview January 7, 2026 18:57 View deployment

armenzg merged commit 91e9e98 into master Jan 7, 2026
67 checks passed

armenzg deleted the 1_5/code_review/pull_request/armenzg branch January 7, 2026 19:15

github-actions bot mentioned this pull request Jan 10, 2026

ci(release): Switch from action-prepare-release to Craft #106005

Open

Uh oh!

feat(code_review): Forward pull_request events to Seer #105740

feat(code_review): Forward pull_request events to Seer #105740

Uh oh!

Conversation

armenzg commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

suejung-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

armenzg commented Jan 6, 2026 •

edited

Loading